RUN-3921: Fixes PR Script to look at merges/tags instead of dates #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the PR feed generation script to use git tag-based comparison instead of date-based queries, making it more accurate for tracking PRs included in specific SaaS deployments. The changes also remove two older PR entries from the feeds and documentation.
Key changes:
- Switched from date-based to tag-based PR fetching using git history comparison
- Added support for SaaS cut tags to limit PRs to specific deployment windows
- Implemented rundeck submodule awareness to correctly track PRs from both repositories
- Removed older PR entries about runner endpoint validation and RSS feed date parsing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/history/updates/index.md | Updated timestamp and removed two older PR entries |
| docs/.vuepress/public/feeds/development.xml | Updated RSS feed timestamp and removed corresponding feed items |
| docs/.vuepress/public/feeds/development-atom.xml | Updated Atom feed timestamp and removed corresponding feed entries |
| docs/.vuepress/pr-feed.mjs | Major refactoring to support tag-based comparison, submodule resolution, and flexible merge strategy detection |
| docs/.vuepress/pr-feed-config.json | Added lastSaasCut field to track deployment cut tags |
| PR-FEED-README.md | Comprehensive documentation update explaining the new tag-based approach and configuration fields |
The engineering team's tag format is perfectly designed for this use case - all the information needed is encoded directly in the tag name!
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PR Script to look at merges/tags instead of dates.