Repository navigation
Update location-display - #19277
Merged
runelite-github-app[bot] merged 5 commits intoOct 27, 2026
Merged
Update location-display#19277
Conversation
Add capitalization config
add build=standard in plugin properties
Member
|
please migrate to filepath per above |
riktenx
added
the
waiting for author
runelite-github-app
Bot
added
size-s
and removed
waiting for author
Contributor
|
You're still using java.io.* in RegionMap.java and SoundEngine.java Also this doesn't impact review but you could update your build.gradle to be based on the current one. Yours is from the 2024-10-04 version. |
rsbfox
added
the
waiting for author
Contributor
Author
|
hey, what are my options here? is using getResourceAsStream not allowed? i have a json in main/resources that i am trying to access and read |
runelite-github-app
Bot
removed
the
waiting for author
Contributor
|
its because youre constructing a FileNotFoundException |
Contributor
Author
|
is that the only change needed to pass? |
Contributor
|
its the only thing currently being flagged to us as a file operation outside of FilePath |
Contributor
Author
thanks for your help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add capitalization config