OSRS Loot Tracker - New Plugin

[kellygrillojr]

The OSRS Loot Tracker Plugin connects to a discord bot that I created. It allows the users to sign into their discord account from the plugin and access the severs in which the bot is installed. They then choose what channels they want the plugin to send their loot to. If a drop is detected over the value of the setting they select, a message is sent to those channels.

The discord bot then logs it to osrsloottracker.com website so they can share/memorialize their drops with the discord server.

[runelite-github-app]

New plugin osrsloottracker: https://github.com/kellygrillojr/OSRSLootTrackerPlugin/tree/985a8098ac9c20234c477065dff4c1863d7a4a9f

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[Felanbird]

Could you not just send the loot to that website, with Dink

[kellygrillojr]

You could, the bot currently scans the channels and logs it that way. But I feel that this is easier to setup/maintain.

[riktenx]

Not a full review but you can't directly use HttpUrlConnection - you need to @Inject runelite's OkHttpClient and use that.

[raiyni]

Also, is there a specific reason you need to open an OAUTH flow to get Identify Guilds when you could use the DiscordService supplied by runelite?

[kellygrillojr]

Not a full review but you can't directly use HttpUrlConnection - you need to @Inject runelite's OkHttpClient and use that.

Okay thanks! I'll make this change tonight

[kellygrillojr]

Also, is there a specific reason you need to open an OAUTH flow to get Identify Guilds when you could use the DiscordService supplied by runelite?

I didn't know runelite supplied this. I'll look into it. Thanks!

[kellygrillojr]

If I understand correctly the Discord service provided by runelite is just for rich presence. My plugin is using its own OAuth flow because of the need to communicate directly with my backend to know which of the users servers have the bot installed.

[riktenx]

do not sleep the shared executor service

[kellygrillojr]

@riktenx the plugin is no longer sleeping the executor service... Thanks!