-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Item Link plugin #9860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Item Link plugin #9860
Conversation
|
New plugin |
|
This would be considered auto typing |
|
Internal use only: Reviewer details Maintainer details |
It just links an item in chat, it does not auto type the whole sentence and you cannot abuse it in any way. It's a plugin that is much needed in the Runelite community as people would love to be able to link items in chat like in other popular MMO's |
|
You are programmatically setting the chatbox input text here - that is autotyping. Plugins are not allowed to modify the content of the chat input buffer whatsoever. The only way in which characters can make it into the input buffer is from users manually typing. What would be allowed instead, if you wanted to accomplish this, is if you instead supported some sort of shorthand that the user typed in, that your plugin then expanded client-side only (again, you cannot modify outgoing messages as that is autotyping). So something like the user entering If you are otherwise unwilling to modify your submission to comply with 3rd-party client guidelines then we'll need to close this PR. |
Okay, thanks. Let me think of another way and I'll resubmit. |
|
You are welcome to leave this pull request open and just update the commit hash. |
|
@riktenx Found a better way. I removed the automatic insert of text into the chatbox. The item will be highlighted automatically when the user sends a message, for example. Hey, I just got an Abyssal Whip! The tooltip will automatically appear in the message (as before) just without breaking the auto typing rule, everything is manual now. Hope this is better! Thanks again. |
|
this startup bulk read from cache may cause you some performance issues but there's not really a better way to do it that i'm aware of so i'm gonna merge this for now |
Would this be the cause of enabling the plugin and typing something in the chat to make it take effect making my game sit at a constant 60 fps to drop down to 7-8 fps even persisting after restarting RuneLite? Disabling the plugin restored my fps |
Item Link Plugin
Link items in chat like WoW - Shift+right-click items to share them with detailed tooltips showing GE price, HA value, equipment stats, and more.
Features
Repository
https://github.com/NorbsCode/item-link