Skip to content

Conversation

@Maewi
Copy link
Contributor

@Maewi Maewi commented Dec 16, 2025

The Deep Sea Trawling plugin is a RuneLite plugin that helps make the Deep Sea Trawling Sailing activity in Old School Runescape easier by helping to track all different kinds of fish shoals and their depths, as well as fish quantity in nets for all net types on skiffs and sloops.

@runelite-github-app
Copy link

@runelite-github-app
Copy link

Internal use only: Reviewer details Maintainer details

@pwatts6060
Copy link
Contributor

pwatts6060 commented Dec 16, 2025

The sailing plugin has a PR open for similar features I believe. I'd also take a look at that to see if it covers the things you do here and potentially add your features into that plugin to avoid having multiple different sailing plugins. LlemonDuck/sailing#189

@Maewi
Copy link
Contributor Author

Maewi commented Dec 16, 2025

The sailing plugin has a PR open for similar features I believe. I'd also take a look at that to see if it covers the things you do here and potentially add your features into that plugin to avoid having multiple different sailing plugins. LlemonDuck/sailing#189

Personally I think that it's fine to have a separate plugin for this activity
I don't think that everyone that wants to train sailing is going to want the Deep Sea Trawling features on by default and people that have the sailing plugin might not even realise it's there

Mostly this was just my first time making a plugin, I started making it before I realised someone else was and was going to abandon it but was encouraged to finish it

If people want it I can put in more config and clean it a bit more and I'll continue to support it
But if people just think it should just go under the sailing plugin I'm happy for my code to be used as a resource for them if they think any of it is worth using

@pwatts6060
Copy link
Contributor

Congrats on your first plugin! That sounds fine, also seems like you have some things working better and I think people will be happy to get a deep-sea trawling plugin asap

@riktenx
Copy link
Member

riktenx commented Dec 16, 2025

it is really up to you @Maewi, contribution to existing plugins is certainly preferred but not required. if you would like this to be a separate plugin we can review this as-is

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 16, 2025
@Maewi
Copy link
Contributor Author

Maewi commented Dec 17, 2025

If it's not a problem, I would like this to be a separate plugin. Even if it's barely used.

it is really up to you @Maewi, contribution to existing plugins is certainly preferred but not required. if you would like this to be a separate plugin we can review this as-is

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 17, 2025
@riktenx riktenx merged commit dfdc92a into runelite:master Dec 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants