Skip to content

Conversation

@Sacca-1
Copy link
Contributor

@Sacca-1 Sacca-1 commented Dec 16, 2025

Added a much requested feature which lets users replace the inventory icons of the marlin and halibut with anglerfish and karambwan respectively. (these are better to discern in a reflex)

I hope this approach is alright. If not, please point me in a better direction.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 16, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 16, 2025

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Dec 19, 2025

You can't make up new menu entries (i.e. client.menuAction) that do things on the server, even if you're just forwarding params of another entry. You can compose/remove/whatever menu entries but you can't do it this way.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 19, 2025
@runelite-github-app runelite-github-app bot added size-s and removed waiting for author waiting for the pr author to make changes or respond to questions size-m labels Dec 19, 2025
@Sacca-1
Copy link
Contributor Author

Sacca-1 commented Dec 19, 2025

Thank you for the feedback, this should be better then.

@riktenx riktenx merged commit 1f2b890 into runelite:master Dec 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants