Make --imageName optional when --templateId is specified #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a pod with --templateId, the image name is already defined in the template on RunPod UI. This removes --imageName as a required flag and adds runtime validation to require it only when --templateId is not set. Fixes runpod#162
pantafive
force-pushed
the
fix/template-id-imagename-optional
branch
from
5302f5b to
b65a681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--imageNameas a required flag forcreate podandcreate podscommands--imageNameonly when--templateIdis not specified--templateId, the image name is already defined in the template on RunPod UIFixes #162