Quality: TOCTOU pattern when checking file existence before stat#2338
Open
tomaioo wants to merge 1 commit intoruntime-env:mainfrom
Open
Quality: TOCTOU pattern when checking file existence before stat#2338tomaioo wants to merge 1 commit intoruntime-env:mainfrom
tomaioo wants to merge 1 commit intoruntime-env:mainfrom
Conversation
`existsSync(path)` followed by `lstatSync(path)` introduces a time-of-check/time-of-use race. Files can disappear between calls, causing unexpected exceptions in concurrent or CI environments. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quality: TOCTOU pattern when checking file existence before stat
Problem
Severity:
Medium| File:packages/cli/src/resolve-output-file-names.ts:L9existsSync(path)followed bylstatSync(path)introduces a time-of-check/time-of-use race. Files can disappear between calls, causing unexpected exceptions in concurrent or CI environments.Solution
Use a single
lstatSyncinside a try/catch and filter based on the result, instead of separateexistsSyncandlstatSynccalls.Changes
packages/cli/src/resolve-output-file-names.ts(modified)