Skip to content

Conversation

@khuey
Copy link
Contributor

@khuey khuey commented May 1, 2025

dup/dup2 now encode their ownership semantics in the type system. Special variants of dup2 were added for the I/O redirection which we use here. dup now takes an Fd instead of a RawFd and returns an OwnedFd, which is directly convertible to a File, so we can get rid of some conversion boilerplate in get_file_handle.

@coveralls
Copy link

coveralls commented May 1, 2025

Pull Request Test Coverage Report for Build 14779987503

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.848%

Totals Coverage Status
Change from base Build 12165539867: 0.0%
Covered Lines: 210
Relevant Lines: 263

💛 - Coveralls

@epage epage merged commit 5e430ef into rust-cli:main May 1, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants