fix: skip ARM unaligned shim during dependency generation - #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM compiler invocations using
-Mor-MM, such as Jemalloc's Makefile dependency generation, were treated as linking commands and received an extraaeabi_unaligned.cinput. With a single-ooutput, Zig rejected the resulting command withcannot specify -o when generating multiple output files.Skip the shim for both dependency-only modes. Keep injecting it for linking, including
-MD/-MMD, which generate dependencies as a side effect. Regression tests exercise the CLI argument path and cover both behaviors plus the existing-c/-E/-Sexclusions.Validation:
cargo test: 59 tests passed; the new dependency-generation test failed before the fix.-Mand-MMinvocations with the reported CPU flag successfully generated dependency files after the fix.cargo fmt --all --checkandgit diff --check: passed.cargo clippy --all-targets --all-features -- -D warnings: blocked by five pre-existing warnings in unchanged code (useless_conversion,useless_borrows_in_formatting, andchunks_exact_to_as_chunks).Fixes #478.