Clarify that relative paths with super start in the parent module - #4835
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
The intro to Chapter 7.3 said a relative path "starts from the current module and uses self, super, or an identifier", which incorrectly implies that `super` also starts from the current module. Distinguish `self` / identifier (current module) from `super` (parent module). Fixes rust-lang#4832
|
The account under which this PR was opened has been banned from the rust-lang org for spamming |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Chapter 7.3 intro currently says a relative path "starts from the current module and uses
self,super, or an identifier in the current module," which reads as ifsuperalso starts from the current module. In realitysuperstarts in the parent module (as the later "Starting Relative Paths withsuper" section already explains).This updates the intro bullet so relative paths are described as starting with
self,super, or an identifier, and then distinguishes where each kind begins: current module forself/ an identifier, parent module forsuper.Fixes #4832
Note
Open PR #4831 also edits this chapter but does not touch this intro sentence (it reworks the post-listing absolute vs relative discussion). These changes should compose cleanly.