Skip tests on 27 crates - #831
Closed
meithecatte wants to merge 1 commit into
Closed
Conversation
meithecatte
force-pushed
the
push-pnmupmqkyolm
branch
from
April 11, 2026 17:09
2c03155 to
8519786
Compare
meithecatte
force-pushed
the
push-pnmupmqkyolm
branch
from
April 12, 2026 17:33
8519786 to
64f0e77
Compare
Member
If they are truly flaky, I would say ignore / skip test is best. I rather not run them at all versus doing weird things like retrying loops... |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2026
Contributor
|
Can this be merged now, given that #835 has been merged? |
Member
|
Looks like it needs a rebase? But otherwise, yes, happy to merge. |
Contributor
|
This PR seems to have been forgotten. Should I make a new PR with the contents of this rebased? |
Member
Go ahead, feel free to ping me on the PR. |
This was referenced Jul 20, 2026
Merged
Contributor
|
This PR was superceded by #842, and can now be closed. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this the best strategy we've got for dealing with flaky tests on crater? Either way, here's some crates for which we should be skipping the tests.