Update diagnostics::do_not_recommend to use the attribute template - #1894
Open
ehuss wants to merge 6 commits into
Open
Update diagnostics::do_not_recommend to use the attribute template#1894ehuss wants to merge 6 commits into
diagnostics::do_not_recommend to use the attribute template#1894ehuss wants to merge 6 commits into
Conversation
rustbot
added
the
S-waiting-on-review
…tions Say the attribute name.
More closely align with the template, and some minor word tweaks.
ehuss
force-pushed
the
do_not_recommend
branch
from
September 22, 2025 20:33
00d451c to
b68e28d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.diagnostic.do_not_recommend.duplicates