-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
try enabling linker-messages by default again
#149937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Hide common linker output behind `linker-info` - Add tests - Account for different capitalization on windows-gnu when removing "warning" prefix
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
try enabling `linker-messages` by default again
This comment has been minimized.
This comment has been minimized.
|
@craterbot build-only |
|
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ask in t-infra on Zulip |
|
@craterbot run mode=build-only |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc `@jieyouxu` `@Oneirical`
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc ``@jieyouxu`` ``@Oneirical``
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc ```@jieyouxu``` ```@Oneirical```
|
☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts. |
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang/rust#149937. cc ```@jieyouxu``` ```@Oneirical```
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
Footnotes
|
|
lots of things that look like There was also someone using intrinsics::type_name() wrong, which caused an ICE, that seems like a real problem but not related to this PR. |
|
I kinda want to do another run but with -C self-contained-linker=no this time. |
|
Most (if not all, I didn't check them all) failures involve static C-based libraries. Moreover, many of them use convoluted ways to build the libraries (I didn't bother checking them), are not quite correct, or even use prebbuild objects. |
No description provided.