Skip to content

Move std::io::read_to_string to alloc::io#158545

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bushrat011899:alloc_io_read_to_string
Jul 18, 2026
Merged

Move std::io::read_to_string to alloc::io#158545
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bushrat011899:alloc_io_read_to_string

Conversation

@bushrat011899

@bushrat011899 bushrat011899 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

View all comments

ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158544

Description

Moves std::io::read_to_string to alloc::io. This is a trivial move. Blocked on #158544.


Notes

@rustbot

rustbot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 29, 2026
@bushrat011899

Copy link
Copy Markdown
Contributor Author

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2026
@rust-bors

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from 63e0a84 to 553848d Compare July 2, 2026 01:58
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch 2 times, most recently from e9c0d4c to 7c579fc Compare July 3, 2026 03:46
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from 7c579fc to 81c200e Compare July 6, 2026 09:32
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from 81c200e to 9764316 Compare July 6, 2026 21:53
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from 9764316 to 5fd480e Compare July 6, 2026 22:22
@rustbot

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from 5fd480e to 45a5755 Compare July 7, 2026 05:29
@rustbot

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from 4acfc7c to e444418 Compare July 10, 2026 05:29
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_read_to_string branch from e444418 to 5de65af Compare July 18, 2026 03:32
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bushrat011899

Copy link
Copy Markdown
Contributor Author

@clarfonthey here's the next one if you're interested, but please don't feel pressured! From here on the PRs are much smaller and easier to review IMO.

@rustbot ready

Labels are from the blocked earlier version of this PR.
@rustbot label -T-compiler -T-rustdoc -T-rustdoc-frontend

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 18, 2026
@clarfonthey

Copy link
Copy Markdown
Contributor

r? clarfonthey

@rustbot rustbot assigned clarfonthey and unassigned jhpratt Jul 18, 2026
@clarfonthey

Copy link
Copy Markdown
Contributor

…oh, this is small, isn't it

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5de65af has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 18, 2026
…ing, r=clarfonthey

Move `std::io::read_to_string` to `alloc::io`

ACP: rust-lang/libs-team#755
Tracking issue: rust-lang#154046
Split From: rust-lang#156527
~~Blocked On: rust-lang#158544

## Description

Moves `std::io::read_to_string` to `alloc::io`. This is a trivial move. Blocked on rust-lang#158544.

---

## Notes

* No AI tooling of any kind was used during the creation of this PR.
* Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic)
 - #158545 (Move `std::io::read_to_string` to `alloc::io`)
 - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - #159470 (Fix string indexing in diagnostic format strings)
 - #159500 (Move compiletest CLI parsing to `cli.rs`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 18, 2026
…ing, r=clarfonthey

Move `std::io::read_to_string` to `alloc::io`

ACP: rust-lang/libs-team#755
Tracking issue: rust-lang#154046
Split From: rust-lang#156527
~~Blocked On: rust-lang#158544

## Description

Moves `std::io::read_to_string` to `alloc::io`. This is a trivial move. Blocked on rust-lang#158544.

---

## Notes

* No AI tooling of any kind was used during the creation of this PR.
* Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`)
 - #158545 (Move `std::io::read_to_string` to `alloc::io`)
 - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - #159470 (Fix string indexing in diagnostic format strings)
 - #159500 (Move compiletest CLI parsing to `cli.rs`)
rust-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #159425 (Windows: add context when opening NUL for child stdio fails)
 - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`)
 - #157860 (Move rustdoc run-make tests into new `tests/run-make/rustdoc/`)
 - #158545 (Move `std::io::read_to_string` to `alloc::io`)
 - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test)
 - #159459 (Detect when trait bound requires closure to return itself)
 - #159470 (Fix string indexing in diagnostic format strings)
 - #159500 (Move compiletest CLI parsing to `cli.rs`)
@rust-bors
rust-bors Bot merged commit caeca00 into rust-lang:main Jul 18, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 18, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 19, 2026
…clarfonthey

Move `std::io::BufRead` to `alloc::io`

ACP: rust-lang/libs-team#755
Tracking issue: rust-lang#154046
Split From: rust-lang#156527
~~Blocked On: rust-lang#158545

## Description

Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158545.

---

## Notes

* No AI tooling of any kind was used during the creation of this PR.
* Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants