Skip to content

allow arguments and return type on extern "custom"#159441

Open
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:lift-extern-custom-restrictions
Open

allow arguments and return type on extern "custom"#159441
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:lift-extern-custom-restrictions

Conversation

@folkertdev

@folkertdev folkertdev commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

tracking issue: #140829

Allow arbitrary signatures for extern "custom" as discussed on the RFC.

cc @tgross35 @Jules-Bertholet @clarfonthey @scottmcm
r? @joshtriplett (or any of the above)

@folkertdev folkertdev added the F-abi_custom `#![feature(abi_custom)]` label Jul 17, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2026
@rustbot

rustbot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

@clarfonthey

clarfonthey commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

r? compiler

Think it's fair for compiler to do the actual code review here, and we can just have someone from lang sign off after them to OK merging this in.

@rustbot rustbot assigned ShoyuVanilla and unassigned joshtriplett Jul 17, 2026
ShoyuVanilla
ShoyuVanilla approved these changes Jul 21, 2026
View reviewed changes

@ShoyuVanilla ShoyuVanilla left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC is saying otherwise and I don't have much context on this so I was a bit confused 😅

But the following comments are saying that we should allow arbitrary signature and the implementation looks correct to me

View changes since this review

@ShoyuVanilla

ShoyuVanilla commented Jul 21, 2026

Copy link
Copy Markdown
Member

Think it's fair for compiler to do the actual code review here, and we can just have someone from lang sign off after them to OK merging this in.

Passing the ball to a lang team member according to the above comment 😄 r? lang

@rustbot rustbot added the T-lang Relevant to the language team label Jul 21, 2026
@rustbot rustbot assigned tmandry and unassigned ShoyuVanilla Jul 21, 2026
@tgross35

tgross35 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

I think the team may want to discuss this, considering FCP on the RFC completed.

@rustbot label +I-lang-nominated

@rustbot rustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label Jul 21, 2026
@traviscross traviscross added the P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

@tmandry tmandry

Labels

F-abi_custom `#![feature(abi_custom)]` I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@folkertdev @rustbot @clarfonthey @ShoyuVanilla @tgross35 @joshtriplett @traviscross @tmandry