rust-analyzer subtree update#159600
Merged
Merged
Conversation
…onstant-sized We used to set a `slice: None`.
The InvocationStrategy::Once path indexed world.flycheck[0] directly. The always!() above only logs in release builds, so when the list was empty it fell through and panicked with index out of bounds. Use first() and skip the restart when there is no handle. Fixes rust-lang/rust-analyzer#21638
They should skip non-module scope (although I think they cannot skip and will do just fine), but must also process block module scopes.
Ask for disclosure in AI contributions
internal: update links to `rustc_hir_analysis`
fix: Resolve non-plain paths in blocks correctly
…tpluxqp feat: Treat library files as truly client immutable
… claude lifetime bound scope
…ztynowk internal: Split out a session construct
feat: early late classification of lifetimes
…ent is used outside of a function
We don't need a new type here thanks to serde's `remote`. This is a follow-up to rust-lang/rust-analyzer#22753 (comment).
fix!: use `Result` for the lsp-server `Response` payload type
Fix: parser to error on macro type bound
feat: Add handler for E0572
…-assignment-array-rest fix: Do not assume array destructuring assignments with rest pattern are constant-sized
These functions would panic when they try to re-parse code that isn't valid in a top level function. For parameters, this is `..`, which is valid in a closure but not a function (requires an annotation). For tail block expressions, this is `let var = expr`, which is valid in a tail position but not a function body (requires a semicolon). I've checked both quote! invocations against the rust.ungram file and I think the structures are correct. Include a test of an assist that previously caused a panic. AI disclosure: Written with a little help by GPT-5.5.
…pping-unwraps Fix crashes in assists due to .unwrap() calls in SyntaxFactory
Collaborator
|
cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
Collaborator
|
Member
Author
|
@bors r+ p=1 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 20, 2026
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@cac0779. Created using https://github.com/rust-lang/josh-sync. r? @ghost
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)
Contributor
|
⌛ Testing commit c19056d with merge 66cb44c... Workflow: https://github.com/rust-lang/rust/actions/runs/29755743467 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@cac0779. Created using https://github.com/rust-lang/josh-sync. r? @ghost
Contributor
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #159344. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)
rust-timer
added a commit
that referenced
this pull request
Jul 20, 2026
Rollup merge of #159600 - lnicola:sync-from-ra, r=lnicola `rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@cac0779. Created using https://github.com/rust-lang/josh-sync. r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@cac0779.Created using https://github.com/rust-lang/josh-sync.
r? @ghost