Replace most `Ty::new_fn_def` calls with `type_of` queries directly by addiesh · Pull Request #159665 · rust-lang/rust

addiesh · 2026-07-21T15:56:47Z

This is so we can reduce the amount of code and changes in #159403. It should stand on its own, but really it's meant as an extended part of 159403.

This allows getting the right ty::FnDef even cross-crate, as the type_of query results are stored in metadata, in contrast to the queries for computing the binder for various declarations. These binders are already cached via fn_sig, but using that is somewhat overkill and can cause cycle errors in some cases.

rustbot · 2026-07-21T15:56:52Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

addiesh · 2026-07-21T16:09:07Z

i wish github supported funnier reactions for PRs so I could 😭 when CI fails

oli-obk · 2026-07-21T16:51:23Z

@bors try @rust-timer queue

Replace most `Ty::new_fn_def` calls with `type_of` queries directly

rust-bors · 2026-07-21T18:57:51Z

☀️ Try build successful (CI)
Build commit: 221275a (221275a593e1700a6824feb1f05823991afce3f1)
Base parent: f65b272 (f65b272fc92b1e7527dea4a224430a249ab25c2d)

rust-timer · 2026-07-22T00:52:13Z

Finished benchmarking commit (221275a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.7%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	3.8%	[2.5%, 5.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-4.0%, -1.5%]	3
All ❌✅ (primary)	1.7%	[1.7%, 1.7%]	1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.1%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	4

Bootstrap: 487.415s -> 487.919s (0.10%)
Artifact size: 387.80 MiB -> 387.86 MiB (0.02%)

rustbot · 2026-07-22T09:46:29Z

HIR ty lowering was modified

cc @fmease

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in match lowering

cc @Nadrieril

rustbot · 2026-07-22T09:51:00Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

addiesh · 2026-07-23T04:00:12Z

@rustbot ready

oli-obk

@bors delegate+

r=me with commit message matching the PR message

View changes since this review

rust-bors · 2026-07-28T13:57:45Z

✌️ @addiesh, you can now approve this pull request!

If @oli-obk told you to "r=me" after making some further change, then please make that change and post @bors r=oli-obk.

View changes since this delegation.

rustbot · 2026-07-28T14:06:25Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

addiesh · 2026-07-28T14:18:17Z

@bors r=oli-obk

rust-bors · 2026-07-28T14:18:20Z

📌 Commit 7b8f260 has been approved by oli-obk

It is now in the queue for this repository.

Replace most `Ty::new_fn_def` calls with `type_of` queries directly This is so we can reduce the amount of code and changes in rust-lang#159403. It should stand on its own, but really it's meant as an extended part of 159403. This allows getting the right `ty::FnDef` even cross-crate, as the `type_of` query results are stored in metadata, in contrast to the queries for computing the binder for various declarations. These binders are already cached via `fn_sig`, but using that is somewhat overkill and can cause cycle errors in some cases.

…uwer Rollup of 14 pull requests Successful merges: - #159990 (Many "predicate"-to-"clause" renamings) - #159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly) - #159687 (rustdoc: Set tracing max_level_info when debug-logging is false) - #160065 (Distinguish the dep-graph index space from the live node count) - #159978 (run intrinsic-test by default on x86_64-gnu) - #160008 (Avoid stale closure recovery state across statements) - #160027 (Add regression test for #132767) - #160030 (Update `browser-ui-test` version to `0.25.0`) - #160046 (Improve consistency of attribute error messages (part 2)) - #160056 (Fix associated function suggestion for generic ADTs) - #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY]) - #160071 (sanitize_standard_fds: clarify macos comment) - #160076 (use unstable features when updating dependencies) - #160088 (fix 404 url in src/doc/rustdoc.md)

Replace most `Ty::new_fn_def` calls with `type_of` queries directly This is so we can reduce the amount of code and changes in rust-lang#159403. It should stand on its own, but really it's meant as an extended part of 159403. This allows getting the right `ty::FnDef` even cross-crate, as the `type_of` query results are stored in metadata, in contrast to the queries for computing the binder for various declarations. These binders are already cached via `fn_sig`, but using that is somewhat overkill and can cause cycle errors in some cases.

…uwer Rollup of 21 pull requests Successful merges: - #159990 (Many "predicate"-to-"clause" renamings) - #159665 (Replace most `Ty::new_fn_def` calls with `type_of` queries directly) - #159687 (rustdoc: Set tracing max_level_info when debug-logging is false) - #160057 (refactor(mir-transform): Calculate optimization status inside `run_passes_inner`) - #160060 (codegen: skip stores for entirely-uninit constant aggregate fields, attempt #2) - #160063 (Fix ICE when dumping the dep graph with the parallel frontend) - #160065 (Distinguish the dep-graph index space from the live node count) - #158038 (Split register_tool into register_attribute_tool and register_lint_tool) - #159776 (remove const hack in alloc) - #159978 (run intrinsic-test by default on x86_64-gnu) - #160008 (Avoid stale closure recovery state across statements) - #160027 (Add regression test for #132767) - #160030 (Update `browser-ui-test` version to `0.25.0`) - #160046 (Improve consistency of attribute error messages (part 2)) - #160056 (Fix associated function suggestion for generic ADTs) - #160069 (Update Rust crate tracing-subscriber to v0.3.23 [SECURITY]) - #160071 (sanitize_standard_fds: clarify macos comment) - #160076 (use unstable features when updating dependencies) - #160092 (miri ui tests: don't run native tests on stage 0) - #160093 (Switch cargo assignments to weihanglo) - #160094 (Update assignment for docs)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 21, 2026

rustbot assigned oli-obk Jul 21, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 21, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 21, 2026

Auto merge of #159665 - addiesh:turbofish-fear-me, r=<try>

221275a

Replace most `Ty::new_fn_def` calls with `type_of` queries directly

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2026

oli-obk marked this pull request as ready for review July 22, 2026 09:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026

oli-obk requested changes Jul 22, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated

Comment thread compiler/rustc_middle/src/ty/sty.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2026

addiesh force-pushed the turbofish-fear-me branch from 7851107 to 9c91d27 Compare July 23, 2026 03:59

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 23, 2026

This comment has been minimized.

Sign in to view

oli-obk requested changes Jul 28, 2026

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 28, 2026

addiesh force-pushed the turbofish-fear-me branch from 9c91d27 to cee59e3 Compare July 28, 2026 14:06

Replace most Ty::new_fn_def calls with type_of queries directly

7b8f260

addiesh force-pushed the turbofish-fear-me branch from cee59e3 to 7b8f260 Compare July 28, 2026 14:13

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2026

JonathanBrouwer mentioned this pull request Jul 28, 2026

Rollup of 11 pull requests #160080

Closed

JonathanBrouwer mentioned this pull request Jul 28, 2026

Rollup of 12 pull requests #160081

Closed

JonathanBrouwer mentioned this pull request Jul 28, 2026

Rollup of 11 pull requests #160082

Closed

JonathanBrouwer mentioned this pull request Jul 28, 2026

Rollup of 14 pull requests #160089

Closed

JonathanBrouwer mentioned this pull request Jul 28, 2026

Rollup of 14 pull requests #160096

Closed

JonathanBrouwer mentioned this pull request Jul 28, 2026

Rollup of 21 pull requests #160102

Open

Uh oh!

Uh oh!

Conversation

addiesh commented Jul 21, 2026 • edited by oli-obk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 21, 2026

Uh oh!

addiesh commented Jul 21, 2026

Uh oh!

oli-obk commented Jul 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 21, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 22, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rustbot commented Jul 22, 2026

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jul 22, 2026

Uh oh!

addiesh commented Jul 23, 2026

Uh oh!

This comment has been minimized.

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

rustbot commented Jul 28, 2026

Uh oh!

addiesh commented Jul 28, 2026

Uh oh!

rust-bors Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

addiesh commented Jul 21, 2026 •

edited by oli-obk

Loading

oli-obk left a comment •

edited by rustbot

Loading