Fix chain formatting with pre-existing overflow - #7006
Open
subotac wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ytmimi
added
the
S-on-hold
Contributor
|
Marking this as on-hold for now. Want to review the change carefully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6977.
A nested expression rewrite could succeed while the final chain width check rejected the entire result because an unchanged string literal already exceeded
max_width.For Style Edition 2027, allow the chain rewrite to retain the widest pre-existing normal-code line without permitting a wider overflow. Style Edition 2024 behavior remains unchanged.
Tests
Added source/target regression fixtures for Style Editions 2024 and 2027.