crates.io: Enable compression for index.crates.io responses#1127
Closed
Turbo87 wants to merge 1 commit into
Closed
crates.io: Enable compression for index.crates.io responses#1127Turbo87 wants to merge 1 commit into
Turbo87 wants to merge 1 commit into
Conversation
This marks complete successful GET responses for Fastly dynamic compression while keeping cached objects uncompressed. It adds `Accept-Encoding` to `Vary` for downstream caches.
Member
|
applied to staging 👍 |
Member
Author
|
after testing this we've realized that the segmented caching on Fastly for index.crates.io is preventing this from working correctly. this will need a different approach unfortunately. it is still tbd what the best approach is, so I'll close this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks complete successful GET responses for Fastly dynamic compression while keeping cached objects uncompressed.
It adds
Accept-EncodingtoVaryfor downstream caches.Related