Handle community review PRs closed and merged too early - #2461
Merged
Urgau merged 1 commit intoJul 11, 2026
Conversation
samueltardieu
approved these changes
Jul 10, 2026
Member
Author
Our current testing setup is too weak to be able to test this unfortunately. |
Kobzol
approved these changes
Jul 11, 2026
Urgau
force-pushed
the
assign-community-reviews-closed-early
branch
from
July 11, 2026 09:32
3342cf0 to
9012984
Compare
Urgau
enabled auto-merge
July 11, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't think reviewers would merge without even assigning themselves, in those cases we should remove the label and not perform auto-assignment.
Happened at rust-lang/rust-clippy#17397 (comment)
cc @DanielEScherzer