Support filtering content mentions by paths#2462
Conversation
|
We have two kind of mentions, the content based one and the filename/filepath one. This PR adds the We should IMO ignore (or better error) on |
While I did primarily add it for content mentions, I do think it makes sense for filename mentions as well. The semantic there is "the primary filename matches and at least one of the paths matches". So, you could use that intersection for "files named xyz, anywhere in one of these five directories", for instance. Or, conversely, "under this prefix, files with one of these names". |
|
Except that's not how it works, filename is really just a path, to be precise a starts-with glob. So if someone wants the "files named xyz, anywhere in one of these five directories" they can already do that: [mentions."library/{dir1,dir2,dir3,dir4,dir5}/xyz"] |
|
@Urgau I had not realized that Okay, I'll reject it during validation. |
|
We used to use the |
Some repositories would like to filter by both paths and content. For instance, any mention of "miri" within "library/". Add support for this.
ad9b55b to
5635e12
Compare
|
Would you mind sending a PR updating the documentation at https://github.com/rust-lang/rust-forge/blob/master/src/triagebot/mentions.md? |
…y, r=Mark-Simulacrum triagebot: cc miri on any special-casing of miri in the standard library --- Blocked until rust-lang/triagebot#2462 is merged and deployed.
Rollup merge of #159152 - joshtriplett:triagebot-miri-library, r=Mark-Simulacrum triagebot: cc miri on any special-casing of miri in the standard library --- Blocked until rust-lang/triagebot#2462 is merged and deployed.
…-Simulacrum triagebot: cc miri on any special-casing of miri in the standard library --- Blocked until rust-lang/triagebot#2462 is merged and deployed.
2 participants
Some repositories would like to filter by both paths and content. For
instance, any mention of "miri" within "library/". Add support for this.