Simplify atomics using lazy
#759
Conversation
tamird
force-pushed
the
cleanup-atomics
branch
6 times, most recently
from
09f7584 to
3a40345
Compare
| #[allow(dead_code, reason = "not used in all backends")] | ||
| mod error; | ||
| #[allow(dead_code, reason = "not used in all backends")] | ||
| mod lazy; |
There was a problem hiding this comment.
We can't unconditionally include lazy. It will cause breakage on platforms without AtomicUsize.
There was a problem hiding this comment.
Which platorms, please? Are they not included in CI?
There was a problem hiding this comment.
Interesting, well it used to be the riscv32imc platforms (which do not have atomics). However, for some reason lazy.rs is building, even on a target like riscv32imc-unknown-none-elf which definitely doesn't have atomics. I'll investigate furthur.
| use core::mem::MaybeUninit; | ||
|
|
||
| mod backends; | ||
| #[allow(dead_code, reason = "not used in all backends")] |
There was a problem hiding this comment.
Remove this, we only want #[allow(dead_code)] on certain methods in the error module.
There was a problem hiding this comment.
There are only two pub (crate) items on the error module and prior to this change they are both marked allow(dead_code). Which methods do you not want this on?
tamird
force-pushed
the
cleanup-atomics
branch
7 times, most recently
from
320758f to
d22e6e5
Compare
There was a problem hiding this comment.
I am not convinced that we should "simplify" the NetBSD backend by reusing the lazy module. The current code is fairly straightforward and self-contained, I don't see significant issues with it.
This PR also introduces a lot of other IMO unnecessary changes out of scope for the purpose declared in the PR title.
tamird
force-pushed
the
cleanup-atomics
branch
from
65f8e51 to
db0767e
Compare
|
Sure, I can break it up into more PRs if you folks prefer. I was just looking for ways to make things a bit more neat. Anyway, I used a macro to introduce |
tamird
force-pushed
the
cleanup-atomics
branch
from
db0767e to
0e346f3
Compare
tamird
force-pushed
the
cleanup-atomics
branch
from
0e346f3 to
c0f53bf
Compare
3 participants
No description provided.