Issue #124 : Symfony6 feature

[Alexandre-T]

Do NOT merge this PR into master!

@rvanlaak , I'm trying to prepare a new version of your awesome bundle. A version only for symfony 5.4.|^6.0 and Php 7.4.|^8.0 .

The bundle now works fine with my Symfony 6.1 application, but I still have problem with the functional test. I already tried to upgrade from nyholm/symfony-bundle-test:1 to nyholm/symfony-bundle-test:2 . But I'm not able to detect the services provided by your bundle.

Any help is welcomed!

[rvanlaak]

Hi @Alexandre-T thanks for your work on this. As the old version of this bundle works fine for lower versions, I think it's fine to release a v4 (or v3, as only betas were released?) that bumps all requirements to package versions that do not require us to keep the BC layers.

So, what about bumping to PHP >=8.0 and Symfony >= 5.4 ?

[Alexandre-T]

I do agree. I'm already removing PHP7.4 and fixing some potential issues with PhpStan

[Alexandre-T]

I'm currently fixing the errors detected by php-stan.

As we prepare a new version, what about to fix parameters and returns with no typehint specified?

The most impacted interface is the serializer itself.

interface SerializerInterface
{
    public function serialize(mixed $data): string;

    public function unserialize(string $serialized): mixed;
}

But I guess impacts won't be so important, because this bundle already provides two internal serializers.

Do you agree with such changes?

(Sorry, I'm not so fluent in English.)

[rvanlaak]

Hi @Alexandre-T , yes feel free to improve the internal interface, as this will be a major bump for everything anyways..

[Chris53897]

->at() and ->withConsecutive() are both not supported in PhpUnit 10 ;(
Maybe there is a trait to solve this. Or later in a seperate PR

[Chris53897]

I made a PR that could fix the remaining test problems

[rvanlaak]

@Chris53897 can you also file a PR for this repo?