Add image size default for encoding. #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'll review this, apologies on the main having some failing builds, I got pulled away part way through cleaning up a feature. |
hschimke
approved these changes
Jul 4, 2025
Collaborator
hschimke
left a comment
hschimke
left a comment
There was a problem hiding this comment.
I may change the defaults later, but this is a good start. Thank you for the submission. Approved and merging soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default size to image encoding. Seems worthwhile since it simplifies the command line a lot for those that, like me, don't have any specific requirements on size.
Side note, I had to branch off an earlier commit since builds are failing on main. The patch should still apply to main though I expect.