CFC: Feature/mockk integration - #188
Open
rybalkinsd wants to merge 2 commits into
Open
Conversation
Owner
Author
|
cc @neisip |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
============================================
- Coverage 90.59% 85.10% -5.50%
- Complexity 127 131 +4
============================================
Files 42 44 +2
Lines 404 443 +39
Branches 49 63 +14
============================================
+ Hits 366 377 +11
- Misses 13 26 +13
- Partials 25 40 +15
Continue to review full report at Codecov.
|
IVSivak
reviewed
May 14, 2020
| */ | ||
| fun Response(init: okhttp3.Response.Builder.() -> Unit): okhttp3.Response { | ||
| return okhttp3.Response.Builder().also(init).build() | ||
| } No newline at end of file |
Owner
Author
|
Codcov tests are expected to fail now. Will bring more when we will discuss the API |
Owner
Author
|
Moved further with mocks. Option 2: Pros:
Cons:
Option 1 was: Will be great to here your thoughts @IVSivak @gokulchandra @DeviantBadge |
Collaborator
|
The first option looks like more commonly used. The second option may be confusing for someone, but it looks concise. |
rybalkinsd
force-pushed
the
feature/mockk-integration
branch
from
May 24, 2020 00:10
67dbe86 to
7bd0ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.