-
Notifications
You must be signed in to change notification settings - Fork 467
next 16 #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR updates project configuration by adding npm command permissions to Claude settings, upgrading Next.js and react-day-picker dependencies, and reformatting TypeScript configuration for Next.js 16 compatibility. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
client/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.claude/settings.local.json(1 hunks)client/package.json(1 hunks)client/tsconfig.json(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
client/**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Frontend: Use Next.js, Tailwind CSS, Shadcn UI, Tanstack Query, Zustand, Luxon, Nivo, and react-hook-form
Files:
client/package.jsonclient/tsconfig.json
🧠 Learnings (1)
📚 Learning: 2025-08-03T17:30:25.559Z
Learnt from: CR
PR: rybbit-io/rybbit#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-03T17:30:25.559Z
Learning: Applies to client/**/* : Frontend: Use Next.js, Tailwind CSS, Shadcn UI, Tanstack Query, Zustand, Luxon, Nivo, and react-hook-form
Applied to files:
client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build Client Images (ubuntu-24.04-arm, linux/arm64)
- GitHub Check: Build Client Images (ubuntu-latest, linux/amd64)
🔇 Additional comments (4)
client/tsconfig.json (2)
18-18: Confirm jsx setting aligns with Next.js 16 requirements.Changing jsx from "preserve" to "react-jsx" enables the React 17+ JSX transform, which removes the need for React imports in JSX files. This is appropriate for Next.js 16 with React 19, but verify that:
- All existing JSX files compile without errors
- No legacy imports of React are required anywhere
- The build succeeds without issues
31-40: Include/exclude updates are appropriate for Next.js 16.Adding ".next/dev/types/**/*.ts" to the include section ensures TypeScript recognizes Next.js-generated type definitions. The multi-line formatting improves readability. This aligns with Next.js 16 best practices.
.claude/settings.local.json (1)
17-19: Claude permissions additions are appropriate.The three new npm-related permissions enable Claude to verify dependencies and test the development environment. The
timeout 30wrapper onnpm run dev:*prevents hanging processes. These are reasonable additions for a Next.js project.client/package.json (1)
69-69: Migration to react-day-picker 9.x is complete and correct.Verification confirms the codebase has been properly updated for v9.x compatibility:
- Custom components (IconLeft, IconRight) follow the v9.x redesigned API pattern
- All classNames properties use v9.x names (day_range_start, day_range_end, day_selected, etc.)
- No deprecated APIs are referenced (useInput hook, onWeekNumberClick callback)
- DateRange type and component props (mode, selected, onSelect) are v9.x compatible
| "luxon": "3.6.1", | ||
| "mapbox-gl": "^3.15.0", | ||
| "next": "15.3.2", | ||
| "next": "^16.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify Next.js 16 stability and compatibility.
Next.js 16.0.0 is beyond my knowledge cutoff. Please confirm that this version is stable for production use and that the existing dev script with --turbopack (line 6) remains compatible.
🌐 Web query:
What is the release status and stability of Next.js version 16.0.0?
💡 Result:
Next.js 16.0.0 is a general-availability (stable) release published by Vercel on October 21, 2025. It promotes several previously experimental features to stable (e.g., React Compiler support), makes Turbopack the default bundler, and requires/upgrades to the matching React release. Vercel’s support policy and upgrade docs indicate Next.js 16 is intended for production use (with the usual recommendation to run the latest Active/Maintenance LTS or patch releases). [1][2][3]
Sources:
[1] Next.js blog — “Next.js 16” (Oct 21, 2025).
[2] Next.js upgrade guide — “Upgrading: Version 16”.
[3] Next.js support policy (canary vs stable and LTS recommendations).
Remove the --turbopack flag from the dev script.
In Next.js 16, the --turbopack flag in scripts is no longer necessary and should be removed. Turbopack is now the default bundler and requires no configuration. Update your dev script to next dev without the flag.
🤖 Prompt for AI Agents
In client/package.json around line 65, the dev script includes the obsolete
--turbopack flag; edit the scripts.dev entry to remove the flag and use "next
dev" (i.e., update the dev command to simply run Next.js dev mode), and check
for any other occurrences of --turbopack in package.json scripts and remove them
as well.
Summary by CodeRabbit