-
Notifications
You must be signed in to change notification settings - Fork 303
IMAP Authentication added to Baikal #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
IMAP auth added: - Standard.php extended, having imap_connection saved into baikal.yaml config file & Webadmin UI got a new conneted field to read/modify the IMAP connection - Server.php modified, to be able to use imap_connection from baikal.yaml Including Sabre.io/dav v4.6.0 IMAP Auth code, some tweaking
The web-admin UI now handles the additional IMAP connection input field as it is in the database settings page: when IMAP selected the field rendered, if not it gots hidden. (No validation built-in)
Fix: remove declaration of non-existent validation-hook
The unchanged IMAP.php from sabre.io/dav got updated: - the Baikal namespace & class extension - the GitHub PR at Baikel using different PHP-CS requirements than the one at Sabre.io/dav -> CS has been aligned to Baikal's one The same CS alignation applied to: - Core/Server.php - Model/Config/Standard.php - Controller/Settings/Standard.php
|
Yepp, it still an open PR and not in the upstream code yet, despite the fact the IMAP auth code is part of Sabre.io/dav, and Baikal is a frontend for Sabre.io/dav. I don't know the reasoning behind. You can go to my fork which is 0.9.6.1 at release level. But, I've updated the fork - so downloading the master will give you the latest Baikal v0.10.1 + this PR in once. If you need I can cross-check it my install procedure still works with Baikal v0.10.1 without modification |
|
Does this auth implementation automatically create new accounts and their calendars & addressbooks? |
|
As far as I recall:
You have have the same questions, I've have had a year ago... I don't remember, sorry. Edit: if it is not in Baikal yet, it seems (based on Davis) not too hard to add. The question is when such PR would be accepted into Baikal's mainline |
|
I ran into a small issue with this code. The webadmin tool is not working for me. I had to add a include to: |
|
@JorisHansMeijer, @narcisgarcia Idk why Created a new release, if you wanna try it out altogether. |

Moving this week from another calendar server to Sabre/dav -> Baikal needed the IMAP auth capability. After checking #52 #869 #656 plus some Google search here is a fully working IMAP auth extension for Baikal, including Webadmin UI and saving the IMAP connection data into baikal.yaml. I'm no PHP coder, used the existing coding style to add the functionality (the PHP-CS fixer throws errors for some reasons, not checked).
Highlights :
Tested with:
Usage:
If you want to disable web-admin UI after your configuration is done:
TODO:
Working code can be downloaded/tested from my fork