Uri in xml response must be url encoded. #1591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Uri is derived from the request with the method getPath, which generates a valid path fragment suitable for file and directory names. In the XML-response to a lock-request the uri is used for lockroot element. If the uri contains a space or german umlauts, a strict client like libneon, which is used in davfs2, refuses the lock reponse and files cannot be copied.
- allow upload of multipe files - uploads are not limited by php upload size using PUT - progress bar for each file
|
I see the second commit here is unrelated and should be removed. Also, it would be great to have a test added in tests/Sabre/DAV/Locks/PluginTest.php. |
Author
|
My fault, the second commit does not belong to this issue. I can try to add a test, but I'm afraid it won't work unless a strict client like libneon performs the test. |
added 2 commits
November 21, 2025 18:50
Author
|
Done:
Before the patch we received a http status value 423. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Uri is derived from the request with the method getPath, which generates a valid path fragment suitable for file and directory names.
In the XML-response to a lock-request the uri is used for lockroot element. If the uri contains a space or german umlauts, a strict client like libneon, which is used in davfs2, refuses the lock reponse and files cannot be copied.