Skip to content

Build plugin with vs2022/scons4.7#22

Draft
MatteoPiovanelli wants to merge 2 commits into
samdze:4.xfrom
MatteoPiovanelli:vs2022_compilation
Draft

Build plugin with vs2022/scons4.7#22
MatteoPiovanelli wants to merge 2 commits into
samdze:4.xfrom
MatteoPiovanelli:vs2022_compilation

Conversation

@MatteoPiovanelli

Copy link
Copy Markdown

this is the PR related to #21

Made members of Bullet protected so they may be accessed in inherited classes

Added methods to increase cycle and lifetime of Bullet, mostly for readability. Use getters/setters rather than fields in bullet kits

… classes

Added methods to increase cycle and lifetime of Bullet, mostly for readability.
Use getters/setters rather than fields in bullet kits
@MatteoPiovanelli

Copy link
Copy Markdown
Author

I'm not entirely sure what the best way is to get rid of the submodule update from this PR

@MatteoPiovanelli

Copy link
Copy Markdown
Author

I'm not sure my changes are all correct.
The video here shows what is currently happening in the second example, off the repo as is (in branch 4.x):
https://github.com/samdze/godot-native-bullets-plugin/assets/19283945/e5c1b37f-776c-4d11-84e2-9890e93b355f

I'm not sure this is the intended behaviour. From the main page here on github I'd think not.

@MatteoPiovanelli

Copy link
Copy Markdown
Author

ok, I found the issue: by using the setter I was resetting the starting_transform, so other computations depending on it would get messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant