Skip to content

scc_reader: preserve background color across mid-row attributes and codes - #569

Merged
palemieux merged 2 commits into
masterfrom
issues/0566-fix-attribute-codes
Nov 13, 2026
Merged

palemieux merged 2 commits into
masterfrom
issues/0566-fix-attribute-codes

Conversation

@palemieux

Copy link
Copy Markdown
Contributor

Closes #566

…odes

---------

Co-authored-by: Devin Heitmueller <dheitmueller@ltnglobal.com>
@palemieux

palemieux commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

@dheitmueller This is based on d97ea9f, but fixes a longstanding oversight that the background color was not kept as a state variable (the root cause of the issue).

@dheitmueller

Copy link
Copy Markdown
Contributor

@dheitmueller This is based on d97ea9f, but fixes a longstanding oversight that the background color was not kept as a state variable (the root cause of the issue).

@palemieux So this looks generally good. My only comment is that your test case has invalid parity for the byte pair, which a later patch I am submitting will cause it to skip that packet. The patch for the parity checking I plan to submit also goes through and fixes all the test cases that have incorrect parity, and I'll make sure your new test is part of that.

Separately, it's an interest corner case I'll see about adding it to my conformance suite in the next version.

@palemieux

Copy link
Copy Markdown
Contributor Author

@dheitmueller Does f5a16ca fix it?

@dheitmueller

Copy link
Copy Markdown
Contributor

@dheitmueller Does f5a16ca fix it?

Yes, this fixes it. With parity checking on, the word is no longer dropped and the red mid-row color is kept.

@palemieux
palemieux merged commit df14900 into master Nov 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCC reader: a foreground attribute code (black) loses the background and does not set the color of the text

2 participants