features for analysis tools - #78
Open
joe-saronic wants to merge 2 commits into
Open
joe-saronic wants to merge 2 commits into
joe-saronic wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a way to access the raw bytes for the most recently parsed SBF message, exposed both on the streaming SbfReader and on the underlying SbfParser, primarily to support inspection/recording use cases.
Changes:
- Extend the parser to retain the raw bytes for the last successfully parsed message and expose them via
last_raw_bytes(). - Expose the same capability on
SbfReaderand document how to use it safely with iteration (preferringwhile letoverfor). - Add tests to ensure skipped noise bytes are not included in the captured raw bytes; bump crate version to
0.18.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/reader.rs |
Adds SbfReader::last_raw_bytes() with usage docs and a test validating capture excludes skipped garbage between frames. |
src/parser.rs |
Tracks last parsed frame bytes in SbfParser (last_raw) and adds last_raw_bytes() plus a test ensuring skipped noise isn’t captured. |
Cargo.toml |
Bumps crate version from 0.17.0 to 0.18.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serdeoperates withallocandno_stdjust like most of the base crate, so nothing of value is lost.Both features are intended to parallel what is already in
liban-rs