Skip to content

features for analysis tools - #78

Open
joe-saronic wants to merge 2 commits into
masterfrom
wiretap
Open

joe-saronic wants to merge 2 commits into
masterfrom
wiretap

Conversation

@joe-saronic

@joe-saronic joe-saronic commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  1. Adds a tap for raw bytes for inspection and recording on the parser and reader. This allows a recorder to operate in parallel with a filter.
  2. Serializable messages for human readable output via JSONL. serde operates with alloc and no_std just like most of the base crate, so nothing of value is lost.

Both features are intended to parallel what is already in liban-rs

@joe-saronic
joe-saronic requested review from freeman94 and a lite review from Copilot August 7, 2026 04:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a way to access the raw bytes for the most recently parsed SBF message, exposed both on the streaming SbfReader and on the underlying SbfParser, primarily to support inspection/recording use cases.

Changes:

  • Extend the parser to retain the raw bytes for the last successfully parsed message and expose them via last_raw_bytes().
  • Expose the same capability on SbfReader and document how to use it safely with iteration (preferring while let over for).
  • Add tests to ensure skipped noise bytes are not included in the captured raw bytes; bump crate version to 0.18.0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/reader.rs Adds SbfReader::last_raw_bytes() with usage docs and a test validating capture excludes skipped garbage between frames.
src/parser.rs Tracks last parsed frame bytes in SbfParser (last_raw) and adds last_raw_bytes() plus a test ensuring skipped noise isn’t captured.
Cargo.toml Bumps crate version from 0.17.0 to 0.18.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/parser.rs
@joe-saronic joe-saronic changed the title added last_raw_bytes access to perser and reader features for analysis tools Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants