This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Delete allocated memory before throwing an exception#3192
Open
SafeCoding233 wants to merge 1 commit intosass:masterfrom
Open
Delete allocated memory before throwing an exception#3192SafeCoding233 wants to merge 1 commit intosass:masterfrom
SafeCoding233 wants to merge 1 commit intosass:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two
deletes for the import entry and thesourcefile entry before an exception is thrown.If the client code captures and tries to recover from the exception, the previous version without delete may cause memory leak.