Skip to content

- include <new> - #519

Open
fbergmann wants to merge 1 commit into
developmentfrom
emscripten-compile-fix
Open

fbergmann wants to merge 1 commit into
developmentfrom
emscripten-compile-fix

Conversation

@fbergmann

Copy link
Copy Markdown
Member

latest emscripten fails to compile libsbml, cause for this is the various std::nothrow statements, that strictly speaking are only available after including

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

latest emscripten fails to compile libsbml, cause for this is the various std::nothrow statements, that strictly speaking are only available after including <new>
@fbergmann
fbergmann requested a review from skeating November 16, 2026 09:31
@fbergmann

Copy link
Copy Markdown
Member Author

@skeating the test failure is independent from this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant