Fix Paths Referencing Consumed Parameters #24442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@odersky it seems to be stable now. I will add some more neg tests. Do you agree with the general direction, or should we try something else? |
Contributor
Author
|
I'm also surprised that reach capabilities would pop up where there are no boxes involved whatsoever. |
* Do not include root capabilities when computing consumed paths. * Adjust exemption check to consider both capability and its reach, except for root capabilities.
bracevac
force-pushed
the
consume-in-constructor-new
branch
from
87012a8 to
a539295
Compare
odersky
reviewed
Nov 17, 2025
| case _ => | ||
| acc | ||
|
|
||
| def capsFromConsumeFields(ref: TermRef): Refs = |
Contributor
There was a problem hiding this comment.
Why do we need that? Would not the path root already contain the field consumed set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #24424
Tasks
checkUse.