Development: Issue#18 (Sourcery refactored)

[sourcery-ai]

Pull Request #19 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the development---signed branch, then run:

git fetch origin sourcery/development---signed
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function init_lcd refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function check_usb refactored with the following changes:

• Use x is None rather than x == None (none-compare)

[sourcery-ai]

Function mount_usb refactored with the following changes:

• Swap if/else to remove empty if body (remove-pass-body)

[sourcery-ai]

Lines 309-340 refactored with the following changes:

• Simplify comparison to boolean (simplify-boolean-comparison)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.19%.

Quality metrics	Before	After	Change
Complexity	3.36 ⭐	3.21 ⭐	-0.15 👍
Method Length	61.57 🙂	61.21 🙂	-0.36 👍
Working memory	7.86 🙂	7.86 🙂	0.00
Quality	77.96% ⭐	78.15% ⭐	0.19% 👍

Other metrics	Before	After	Change
Lines	335	329	-6

Changed files	Quality Before	Quality After	Quality Change
linux/dumper/dumper_lcd.py	77.96% ⭐	78.15% ⭐	0.19% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
linux/dumper/dumper_lcd.py	mount_usb	4 ⭐	141 😞	14 😞	53.30% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.