Raise error when fundamental callback is not implemented #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling for fundamental callbacks in plugin base classes by raising NotImplementedError instead of printing error messages. This change enforces proper implementation of required methods in derived classes and aligns with the pattern already established in other plugins like pricer and branchrule.
- Replaces print statements with
NotImplementedErrorexceptions for fundamental callbacks - Updates error messages to follow a consistent pattern across all plugin types
- Affects 7 plugin files: propagator, presol, heuristic, event, conshdlr, benderscut, and benders
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pyscipopt/propagator.pxi | Raises NotImplementedError for propexec() and propresprop() fundamental callbacks |
| src/pyscipopt/presol.pxi | Raises NotImplementedError for presolexec() fundamental callback |
| src/pyscipopt/heuristic.pxi | Raises NotImplementedError for heurexec() fundamental callback |
| src/pyscipopt/event.pxi | Raises NotImplementedError for eventexec() fundamental callback |
| src/pyscipopt/conshdlr.pxi | Raises NotImplementedError for consenfolp(), consenforelax(), consenfops(), conscheck(), and conslock() fundamental callbacks |
| src/pyscipopt/benderscut.pxi | Raises NotImplementedError for benderscutexec() fundamental callback |
| src/pyscipopt/benders.pxi | Raises NotImplementedError for benderscreatesub() and bendersgetvar() fundamental callbacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as was done in other plugins (eg, pricer).