Fix failing structured trace handler reuse test on master - #1246
Open
MySweetEden wants to merge 1 commit into
Open
Fix failing structured trace handler reuse test on master#1246MySweetEden wants to merge 1 commit into
MySweetEden wants to merge 1 commit into
Conversation
MySweetEden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
test_structured_optimization_trace_reuses_handler_for_repeated_contexts, which is currently failing onmaster.On the Windows runner, the one-second time limit could be exhausted during presolving, before any trace event was emitted. This left the trace with only a
run_endrecord and caused the test to fail.This PR:
_model()Why this was not caught before merge
The failure was detected only after merging because the
Integration testworkflow runs on pushes tomaster, but not on pull requests.Follow-up
I propose tracking the pre-merge CI coverage gap in a separate issue, including whether the
Integration testworkflow should run before merge. This PR leaves the CI configuration unchanged and is limited to fixing the failing test.