Open
Conversation
Signed-off-by: hs05june <harpreet.singh.cse21@itbhu.ac.in>
Signed-off-by: hs05june <harpreet.singh.cse21@itbhu.ac.in>
SahanDisa
requested changes
May 14, 2023
| <meta charset="UTF-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="icon" href="./assets/logos/Image Lab icon.ico" /> |
Collaborator
There was a problem hiding this comment.
is this file name conventionable? Please use a proper naming convention for file imports (CamelCase or snake_case)
Collaborator
|
@hs05june Are you working on this issue and able to make the fixes? |
|
@SahanDisa Could i chip in here and just complete the changes you requested from @hs05june . This branch seems to behind so could you confirm whether these are all the required changes or the new versions of code require different implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and state which issue is fixed or which new feature implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Also, include screenshots for verification and reviewing purpose.
Checklist: