[MRG+1] fixes #15 with negative look-ahead regexp#16
[MRG+1] fixes #15 with negative look-ahead regexp#16rriemann wants to merge 1 commit intoscrapinghub:masterfrom
Conversation
| # other | symbols should be escaped | ||
| # we have "|$" in our regexp - do not touch it | ||
| rule = re.sub("(\|)[^$]", r"\|", rule) | ||
| rule = re.sub("(\|)(?!\$)", '\|', rule) |
There was a problem hiding this comment.
💄 I would add the r prefix to both strings instead of removing it, for future-proofing. But the suggested changes should work.
| rule = re.sub("(\|)(?!\$)", '\|', rule) | |
| rule = re.sub(r"(\|)(?!\$)", r'\|', rule) |
There was a problem hiding this comment.
That's too long ago. I changed projects long ago. Do I have to accept the suggestions or could you do it as well?
There was a problem hiding this comment.
We can, don’t worry, and it’s not a deal breaker anyway. I’ll wait for a second approval, though.
PS: Thank you very much for your patch, I’m deeply sorry for the delay.
Gallaecio
changed the title
|
The modification didn't pass the continuous-integration/travis-ci/pr because of failure on pypy, so it isn't available on current github code. Would you consider fix this? Also, the other pull requests modification isn't available as well. |
|
This is not blocked by the CI failure, it only requires a second maintainer to approve. |
3 participants
No description provided.