Skip to content

Conversation

@rosics-code
Copy link

Changes:

Adds ‘membership’ tag to account dropdown.

Test Coverage:

Not right now.

@rosics-code rosics-code changed the base branch from develop to release/membership-program November 24, 2025 15:27
@redspacecat
Copy link

Isn't the account dropdown supposed to be stuff relating to your account?
A link to the general membership page doesn't seem like it would fit in very well. I feel like that should go in the nav bar or the footer.

@rosics-code
Copy link
Author

Isn't the account dropdown supposed to be stuff relating to your account? A link to the general membership page doesn't seem like it would fit in very well. I feel like that should go in the nav bar or the footer.

Membership is related to account .

@cambegonefr
Copy link

Please stop fear mongering

@medlans
Copy link

medlans commented Nov 24, 2025

Isn't the account dropdown supposed to be stuff relating to your account? A link to the general membership page doesn't seem like it would fit in very well. I feel like that should go in the nav bar or the footer.

Membership was added in the navbar for signed out accounts and appears in the footer already (only on scratch-www though). I honestly think this and that other banner thing that you made (talking about Rosics) is even more excessive

@unconstructable13
Copy link

No support. This is literally just advertising the membership again isn’t it

@rosics-code rosics-code changed the title feat: Add ‘membership’ to account dropdwon feat: Add ‘membership’ to account dropdown Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants