Skip to content

feat: Add Conjugate tab to Conjugate app (#563)#585

Open
Mounil2005 wants to merge 3 commits intoscribe-org:mainfrom
Mounil2005:add/conjugate-tab-ui-clean
Open

feat: Add Conjugate tab to Conjugate app (#563)#585
Mounil2005 wants to merge 3 commits intoscribe-org:mainfrom
Mounil2005:add/conjugate-tab-ui-clean

Conversation

@Mounil2005
Copy link
Copy Markdown
Contributor

Contributor checklist


Description

This PR introduces the "No Data" empty state for the Conjugate App tab, enabling users to download the necessary conjugation data before proceeding.

Key Changes:

  • ConjugateScreen.kt
    (New): Adds the "No Data" UI for the Conjugate Tab, reusing the keyboard's download button (DownloadDataOptionComp) for consistent styling. Includes Android Studio previews.
  • ConjugateViewModel.kt
    (New): Tracks data availability (isDataAvailable) to switch between the empty state and the future conjugation UI.
  • App.kt: Replaces the placeholder text with ConjugateScreen, connecting it to the app's existing theme and download logic.

Testing:

  • Verified Gradle build succeeds without AAPT2 duplication errors on string resources.
  • Verified @Preview components render the expected Light and Dark mode variations accurately directly in Android Studio.

Related issue

Closes #563

Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
@github-actions
Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Mounil2005 Mounil2005 marked this pull request as draft March 26, 2026 10:28
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
@Mounil2005
Copy link
Copy Markdown
Contributor Author

Hey @andrewtavis pls let me know in case of any changes!

@Mounil2005 Mounil2005 marked this pull request as ready for review March 27, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Conjugate tab to Conjugate app with download data menu option

1 participant