Skip to content

conjugation tense filte#587

Closed
haasham1 wants to merge 1 commit intoscribe-org:mainfrom
haasham1:conjugation-tense-filter
Closed

conjugation tense filte#587
haasham1 wants to merge 1 commit intoscribe-org:mainfrom
haasham1:conjugation-tense-filter

Conversation

@haasham1
Copy link
Copy Markdown

@haasham1 haasham1 commented Mar 29, 2026

Summary

This PR adds a dropdown filter to the verb conjugation UI that allows users to select and view conjugations for a specific tense.

Changes

  • Added a dropdown UI component for selecting tenses
  • Dynamically populated tense options based on language data contracts
  • Implemented filtering logic to display only the selected tense
  • Updated UI to reflect filtered conjugation results using a database query (SQLite WHERE clause)

Approach

  • Extracted available tenses from the language-specific data contracts
  • Used these values to populate the dropdown options dynamically
  • On selection, the app queries the local database and filters conjugations by the selected tense
  • Ensured that only the relevant tense is displayed in the UI

Testing

  • Verified dropdown populates correctly for supported languages
  • Verified filtering works for each tense selection
  • Tested UI behavior when switching between tenses
  • Ensured no regressions in conjugation display

Related Issue

Closes #572

@github-actions
Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Made-with: Cursor
@haasham1 haasham1 force-pushed the conjugation-tense-filter branch from fb5adda to ffe7d69 Compare March 29, 2026 23:30
@andrewtavis
Copy link
Copy Markdown
Member

Closing this as the underlying issue, #572, is currently blocked and we have failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the user to filter for conjugations by tense

2 participants