Skip to content

Keyboard#591

Closed
haasham1 wants to merge 2 commits intoscribe-org:mainfrom
haasham1:keyboard
Closed

Keyboard#591
haasham1 wants to merge 2 commits intoscribe-org:mainfrom
haasham1:keyboard

Conversation

@haasham1
Copy link
Copy Markdown

Description

Added a download bar to the Scribe keyboard that appears when language data is
not installed. Users can tap the bar to download data from the Scribe app.

Changes

  • Display a blue download bar when language data is missing
  • Hide smart features until data is available
  • Open the Scribe app when the user taps the download bar

Testing

  • Download bar shows/hides based on data availability
  • Tapping bar opens Scribe app
  • All buttons work after the data is downloaded

Issue
#581

@github-actions
Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Copy Markdown
Member

Closing this, @haasham1, as you sent along files for your agent to the repo and the app is not building among the many failing tests. It would be better if someone else worked on this issue. Please see the mentorship and growth section of the contribution guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants