fix : resolve mypy no-untyped-def#679
Merged
andrewtavis merged 5 commits intoscribe-org:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
Thank you for the pull request! 💙🩵The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Contributor
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
Contributor
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Data repo (can be set withgit config --global user.email "GITHUB_EMAIL")
andrewtavis
approved these changes
Mar 31, 2026
andrewtavis
added a commit
to ashb155/Scribe-Data
that referenced
this pull request
Mar 31, 2026
* mypy no-untyped-def fixes * ruff formatting fix * Add mypy to workflows and disable certain errors --------- Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
This PR adds missing return type and parameter type annotations across the codebase to resolve all
no-untyped-defmypy errors.Files changed:
check/check_missing_forms/— annotated 17 functions acrosscheck_missing_forms.py,generate_query.py,get_forms.py,normalize_forms.py,pr_body.py, andsplit_query.py; addedPathimport tosplit_query.pycheck/check_project_metadata.py,check_project_structure.py,check_pyicu.py,check_query_forms.py— annotated 18 functions totalcli/— annotated 26 functions acrosscli_utils.py,contracts/filter.py,convert.py,download.py,get.py,interactive.py,total.py, andversion.py; addedCallableimport todownload.py; widened return types oncorrect_data_typeandwd_lexeme_dump_download_wrapperload/data_to_sqlite.py— annotated 3 functionsunicode/— annotated 5 functions acrossgenerate_emoji_keywords.py,process_unicode.py,unicode_utils.py, andupdate_unicode_data.pyutils.py— annotated 6 functionswikidata/— annotated 12 functions acrosscheck_query/check.py,format_data.py,parse_dump.py,query_data.py, andwikidata_utils.pyTesting: Ran
pytestand verified nono-untyped-deferrors remain withmypy src/scribe_data --enable-error-code no-untyped-def.Related issue