Skip to content

fix : resolve mypy no-untyped-def#679

Merged
andrewtavis merged 5 commits intoscribe-org:mainfrom
ashb155:fix/mypy-no-untyped-def
Mar 31, 2026
Merged

fix : resolve mypy no-untyped-def#679
andrewtavis merged 5 commits intoscribe-org:mainfrom
ashb155:fix/mypy-no-untyped-def

Conversation

@ashb155
Copy link
Copy Markdown
Contributor

@ashb155 ashb155 commented Mar 30, 2026

Contributor checklist


Description

This PR adds missing return type and parameter type annotations across the codebase to resolve all no-untyped-def mypy errors.

Files changed:

  • check/check_missing_forms/ — annotated 17 functions across check_missing_forms.py, generate_query.py, get_forms.py, normalize_forms.py, pr_body.py, and split_query.py; added Path import to split_query.py
  • check/check_project_metadata.py, check_project_structure.py, check_pyicu.py, check_query_forms.py — annotated 18 functions total
  • cli/ — annotated 26 functions across cli_utils.py, contracts/filter.py, convert.py, download.py, get.py, interactive.py, total.py, and version.py; added Callable import to download.py; widened return types on correct_data_type and wd_lexeme_dump_download_wrapper
  • load/data_to_sqlite.py — annotated 3 functions
  • unicode/ — annotated 5 functions across generate_emoji_keywords.py, process_unicode.py, unicode_utils.py, and update_unicode_data.py
  • utils.py — annotated 6 functions
  • wikidata/ — annotated 12 functions across check_query/check.py, format_data.py, parse_dump.py, query_data.py, and wikidata_utils.py
  • Ensured Ruff formatting on changes to ensure compliance with project standards

Testing: Ran pytest and verified no no-untyped-def errors remain with mypy src/scribe_data --enable-error-code no-untyped-def.

Related issue

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo (can be set with git config --global user.email "GITHUB_EMAIL")

@ashb155 ashb155 changed the title Fix/mypy no untyped def fix : resolve mypy no-untyped-def Mar 30, 2026
Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks so much for the update of the functions, @ashb155! This is a great first step in the work on #678 🚀

andrewtavis added a commit to ashb155/Scribe-Data that referenced this pull request Mar 31, 2026
* mypy no-untyped-def fixes

* ruff formatting fix

* Add mypy to workflows and disable certain errors

---------

Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>
@andrewtavis andrewtavis merged commit a33ffe5 into scribe-org:main Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants