-
Notifications
You must be signed in to change notification settings - Fork 389
Upgrade-5: prover Refactor
#1446
Conversation
Btw this time we upgraded rust version and many low level libraries. So for now better only testing this branch, later we will pick some needed changes to v0.13 for dual version support.. |
| /// accumulator. | ||
| /// | ||
| /// Every SNARK layer on top of the [`innermost layer`][LayerId::Inner] has an accumulator. | ||
| pub fn accumulator(&self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to has_accumulator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a planned change. I have not yet removed the has_accumulator argument from function calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good refactor of Err and Proof.
can be merged after e2e testing in scroll-prover
|
i will help with e2e testing. |
|
need to change to BatchProofV2? |
Description
Refactor the
provercrate for:Notice
Requires re-running e2e tests and debugging potentially regression issues in the
provercrate's behaviour:scroll-prover: https://github.com/scroll-tech/scroll-proverscroll/prover: https://github.com/scroll-tech/scroll/tree/develop/prover