Support Galileo #214
Draft
Support Galileo #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-chunk-circuit
github-actions
bot
removed
crate-chunk-circuit
github-actions
bot
added
crate-chunk-circuit
roynalnaruto
force-pushed
the
feat/galileo
branch
2 times, most recently
from
3d0785e to
01195ce
Compare
lispc
reviewed
Nov 14, 2025
| stf_version: STFVersion::V1, | ||
| fork: ForkName::Feynman, | ||
| codec: Codec::V9, | ||
| codec: Codec::V8, |
Collaborator
Author
There was a problem hiding this comment.
yes, codec is v8, so we don't need to define more variants for now. But we compare against stf-version in batch header and blob version byte. So it is ok for now.
lispc
reviewed
Nov 14, 2025
| /// The compression ratios for each block in the chunk. | ||
| pub compression_infos: Vec<Vec<(U256, usize)>>, | ||
| /// The compression info for each block in the chunk. | ||
| pub compression_infos: Vec<ScrollTxCompressionInfos>, |
Collaborator
Author
There was a problem hiding this comment.
ScrollTxCompressionInfos is just an alias for <Vec<U256, usize>>, defined in scroll-revm
Collaborator
|
seems good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #210
Closes #212