docs: correct test-suite check count in README#1
Open
scumunna wants to merge 1 commit into
Open
Conversation
The README overstated the known-answer check count in two places. The test runner reports ~409 checks (272 check() calls plus close() assertions), so the README now says 400+ to match what Scripts/test.sh actually runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
scumunna
pushed a commit
that referenced
this pull request
Jun 20, 2026
…ne import, SKAN 4 (CTO review) adops-13: new 'Strengthen the match' step (click-id capture gclid/fbclid, Enhanced Conversions / Advanced Matching) with an identifier-normalization drill (the #1 silent EMQ killer, now a graded quiz + predict); Consent Mode v2 polish (names ad_user_data/ad_personalization, basic vs advanced). adops-14: new 'Offline and delayed conversions' step (CRM offline import keyed by stored click id, with the window caveat) and SKAN 4 hierarchical fine/coarse conversion values + AdAttributionKit; checklist extended with click-id capture + offline import + normalization. Closes the Pedagogy (normalization drill) and Industry (Enhanced Conversions / click-id / offline import / SKAN hierarchy) gaps from the re-review. ./Scripts/test.sh: all 5,111 checks pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the BidLab README, which claimed "2,500+ checks" in two places. The test runner (
Scripts/test.sh) actually reports ~409 known-answer checks (272check()calls plusclose()assertions), so both mentions now read "400+ checks" to match what the suite runs.Documentation accuracy only; no code or test changes.
🤖 Generated with Claude Code