fix(app): correct the in-app version (Info.plist as single source of truth)#11
Merged
Conversation
… truth The About box hardcoded "BidLab 1.0" and Info.plist's CFBundleShortVersionString was 1.0.0 — two stale, unlinked declarations, even though v1.1.1 shipped and main now carries post-1.1.1 features (the web explorable suite, the Pixel Setup module + native widgets, conversion tracking, the acceptance suite, and 100% coverage gates). Bump Info.plist to 1.2.0 (a minor release for the new features; build 4) and have SettingsSurface read CFBundleShortVersionString from the bundle, so the version lives in one place and the About box cannot drift again. Verified: app builds (release), the built bundle reports 1.2.0, core suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The About box hardcoded "BidLab 1.0" and
Info.plist'sCFBundleShortVersionStringwas 1.0.0 — two stale, unlinked declarations, even though v1.1.1 shipped andmainnow carries a batch of post-1.1.1 features.Change
Info.plist→CFBundleShortVersionString = 1.2.0,CFBundleVersion = 4.SettingsSurfacenow readsCFBundleShortVersionStringfrom the bundle instead of a hardcoded string, soInfo.plistis the single source of truth and the About box can't drift again.Why 1.2.0 (your call to change)
mainhas, since the 1.1.1 release: the free web explorable suite, the step-by-step Pixel Setup module + native widgets, the conversion-tracking engine, the 100-scenario acceptance suite, and 100% coverage gates on both engines. That's a backward-compatible feature batch → a minor bump by semver. If you'd rather cut this as 1.1.2 (patch) or anything else, it's a one-line change inInfo.plistnow.Verified
./Scripts/build.sh release→ builds clean.CFBundleShortVersionString = 1.2.0(so the About box shows "BidLab 1.2.0")../Scripts/test.sh→ 5,271 checks pass.🤖 Generated with Claude Code