feat(content): wire the hero Trading Floor into the impression-valuation lesson#12
Merged
Merged
Conversation
…ion lesson dsp-04 computes an impression's expected value (pCTR x pCVR x V_conv = $1.00 in its worked example), then explains valuation is only the ceiling and bidding decides how much of it to pay -- but gave no way to do that step. Embed the hero bidPlayground (value: 1.0, matching the lesson's example) in the "From value to bid" section so the learner drags the bid against the win-rate curve and sees the optimal shaded bid below the value. Near-zero engine cost; the widget already exists and the validator stays green (5,272 checks). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap depth item 2.1 — "make it do, not read" — applied to the one clearly-apt lesson still missing the hero.
Change
dsp-04 "Impression valuation"teachesvalue = pCTR × pCVR × V_conv(its worked example lands at $1.00), then closes with "valuation is the ceiling; bidding decides how much to pay" — with no interactive to actually do that step. This embeds the herobidPlayground(value: 1.0, matching the example) in the "From value to bid" section, so the learner drags the bid against the win-rate curve and sees the optimal shaded bid sit below the value.Scope note (recalibration)
Scoping revealed the hero is already embedded in 9 lessons (dsp-02/03/06/13, core-02, foundations-04, ai-05, engineering-05, vertical-ecommerce-05) — not the "2/333" the original roadmap assumed. dsp-04 was the one remaining lesson where the hero is an obvious fit (dsp-01 is OpenRTB anatomy, dsp-05 is prediction, foundations-06 already uses the apt
budgetAllocator). So hero-wiring (2.1) is essentially complete with this PR.The larger remaining "read, not do" lever is the 164 static charts (116
barChart+ 30lineChart+ 18donutChart) — converting the apt ones to live interactives. That's a bigger, judgment-heavy effort worth scoping deliberately.Verified
./Scripts/test.sh→ 5,272 checks pass (lesson parses, the section stays interactive, widget type known).🤖 Generated with Claude Code